-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicating test code between e2e & canary #2054
Comments
One way to tackle this would be to have a separate package which would contain the test suites. That way we would not clutter the original package. OTOH this is not ideal for tests like Aztec RPC Server because this breaks a norm a bit because the unit test would not longer be in the same package. |
This is pretty much what I have in mind. |
Fixes #2054 Refactoring so that CLI & Browser e2e tests share code from `end-to-end`
We have a few tests that run the same path in both e2e & canary flows. We previously used test suites exported from the tested package itself but this is not a great solution, as it pollutes the actual code that's necessary to run the packages.
We should figure out a way to share the test code without exporting it from the packages
The text was updated successfully, but these errors were encountered: