Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SafeMath testing #1965

Closed
Tracked by #1795
LHerskind opened this issue Sep 4, 2023 · 0 comments · Fixed by #1967
Closed
Tracked by #1795

SafeMath testing #1965

LHerskind opened this issue Sep 4, 2023 · 0 comments · Fixed by #1967
Assignees
@LHerskind
Labels
A-internal-devex Area: Relates to the devex of internal teams building Aztec. T-fix Type: fix this. Not quite a bug. T-testing Type: Testing. More tests need to be added.

Comments

@LHerskind
Copy link
Contributor

Add noir tests for safe math logic, to ensure that it throws when needed.

Ideally uses noir-lang/noir#2541 to ensure that failures are do to specific reasons, but can use noir-lang/noir#1994 temporarily.
@LHerskind LHerskind added T-fix Type: fix this. Not quite a bug. T-testing Type: Testing. More tests need to be added. A-internal-devex Area: Relates to the devex of internal teams building Aztec. labels Sep 4, 2023
@LHerskind LHerskind added this to the 📢 Initial Public Sandbox Release milestone Sep 4, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 4, 2023
@LHerskind LHerskind mentioned this issue Sep 4, 2023
Closed
@LHerskind LHerskind self-assigned this Sep 4, 2023
@LHerskind LHerskind mentioned this issue Sep 4, 2023
Merged
4 tasks
@LHerskind LHerskind moved this from Todo to In Progress in A3 Sep 4, 2023
@LHerskind LHerskind mentioned this issue Sep 5, 2023
Closed
LHerskind added a commit that referenced this issue Sep 5, 2023
@LHerskind
test: Add safemath noir testing (#1967)
cb1f1ec 
Fixes #1965 with should fail test cases. Should be redone with complete
failure messages when noir-lang/noir#2541 is
ready.
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
A-internal-devex Area: Relates to the devex of internal teams building Aztec. T-fix Type: fix this. Not quite a bug. T-testing Type: Testing. More tests need to be added.
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add safemath noir testing AztecProtocol/aztec-packages
1 participant
@LHerskind