Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloading transcript uses two different URLs for G1 and G2 #1747

Closed
kevaundray opened this issue Aug 22, 2023 · 0 comments · Fixed by #1748
Closed

Downloading transcript uses two different URLs for G1 and G2 #1747

kevaundray opened this issue Aug 22, 2023 · 0 comments · Fixed by #1748
Labels
C-bb.js Component: bb.js - wrapping bberg in js

Comments

@kevaundray
Copy link
Contributor

kevaundray commented Aug 22, 2023 •
edited
Loading

Problem

When we download the SRS, we use a monomial scoped URL for G1 and a sealed scoped URL for G2.

It should be the case that we can use a single URL for both.

Solution

The monomial URL is newer, it differs from the sealed transcript in that it contains the generator point, so we should switch to that and fix the off-by-one error
@kevaundray kevaundray added the C-bb.js Component: bb.js - wrapping bberg in js label Aug 22, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 22, 2023
@kevaundray kevaundray mentioned this issue Aug 22, 2023
Merged
4 tasks
kevaundray added a commit that referenced this issue Aug 22, 2023
@kevaundray
fix: Download SRS using one canonical URL across the codebase (#1748)
899b055 
resolves #1747 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bb.js Component: bb.js - wrapping bberg in js
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Download SRS using one canonical URL across the codebase AztecProtocol/aztec-packages
1 participant
@kevaundray