You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because the contract developers will know what data would be shared offline, it makes sense for them to provide the proper apis accordingly.
This should replace the previous proposal of adding addPreimage(contract_address, storage_slot, preimage) api to the AztecRPCServer. Which will require the users to provide the storage_slot. And might not be obvious what's been added.
The text was updated successfully, but these errors were encountered:
The previous `Set.assert_contains` can be misleading.
A note in a Set might have been destroyed. But this could still generate
a valid proof:
```rust
set.assert_contains(note);
do_something();
```
However, the ability to check if a note hash exists is useful. Because a
note might not be shared via log. In which case, the user gets the
preimage offline, and should be able to call a contract function with
the preimage to claim a note or do something.
Before we add the [feature](#1635) properly, we can use
`assert_contains_and_remove` to check that the note hash does exist, and
destroy the note right after, to prevent developers making wrong
assumption.
# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
We should let the contracts define what can be stored.
Sometimes the information of notes are shared offline. And the users should be able to either:
Because the contract developers will know what data would be shared offline, it makes sense for them to provide the proper apis accordingly.
This should replace the previous proposal of adding
addPreimage(contract_address, storage_slot, preimage)
api to the AztecRPCServer. Which will require the users to provide the storage_slot. And might not be obvious what's been added.The text was updated successfully, but these errors were encountered: