Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test to replicate: public kernel rejects a perfectly valid sequence of public state updates #1616

Closed
Tracked by #1601
dbanks12 opened this issue Aug 17, 2023 · 0 comments · Fixed by #1661
Closed
Tracked by #1601

Test to replicate: public kernel rejects a perfectly valid sequence of public state updates #1616

dbanks12 opened this issue Aug 17, 2023 · 0 comments · Fixed by #1661
Assignees
@dbanks12
Labels
T-bug Type: Bug. Something is broken. T-testing Type: Testing. More tests need to be added.
Milestone
🚀 Initial F&F San...

Comments

@dbanks12
Copy link
Collaborator

No description provided.

@dbanks12 dbanks12 added T-bug Type: Bug. Something is broken. T-testing Type: Testing. More tests need to be added. labels Aug 17, 2023
@dbanks12 dbanks12 added this to A3 Aug 17, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 17, 2023
This was referenced Aug 17, 2023
Closed
Closed
Closed
Closed
@dbanks12 dbanks12 mentioned this issue Aug 18, 2023
Merged
@dbanks12 dbanks12 moved this from Todo to In Progress in A3 Aug 18, 2023
@dbanks12 dbanks12 moved this from In Progress to In Review in A3 Aug 18, 2023
dbanks12 added a commit that referenced this issue Aug 18, 2023
@dbanks12
test: add tests that check ordering of public state updates (#1661)
5b9aedd 
Resolves #1616 

Added two tests:
* Setting public state value first directly, then again in a nested call
works, but
* Setting public state value first in a nested call, then directly
*fails*, but it shouldn't!
* Test commented out for now. Can be reenabled once public state
ordering is done or once we hack around this (#1622)
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbanks12 dbanks12

Labels
T-bug Type: Bug. Something is broken. T-testing Type: Testing. More tests need to be added.
Projects
A3
Archived in project
Milestone
🚀 Initial F&F Sandbox Release
Development

Successfully merging a pull request may close this issue.

test: add tests that check ordering of public state updates AztecProtocol/aztec-packages
2 participants
@dbanks12 @jeanmon