refactor: required option in aztec-cli #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -143,10 +143,9 @@ export function getProgram(log: LogFn, debugLogger: DebugLogger): Command { | |||
| program | |||
| .command('deploy') | |||
| .description('Deploys a compiled Noir contract to Aztec.') | |||
| .option( | |||
| .requiredOption( | |||
There was a problem hiding this comment.
Are --salt and --public-key also a required options, here? (Does it work without them, given they're defaulting to undefined values?)
There was a problem hiding this comment.
Hello, yes in this case it works without them just fine.
Co-authored-by: Michael Connor <[email protected]>
iAmMichaelConnor
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1520
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.