Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make required options in AztecCLI 'requiredOption' #1520

Closed
PhilWindle opened this issue Aug 11, 2023 · 0 comments · Fixed by #1584
Closed

Make required options in AztecCLI 'requiredOption' #1520

PhilWindle opened this issue Aug 11, 2023 · 0 comments · Fixed by #1584
Assignees
@benesjan
Labels
A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex)
Milestone
🚀 Initial F&F San...

Comments

@PhilWindle
Copy link
Collaborator

PhilWindle commented Aug 11, 2023 •
edited
Loading

As an example, to register a public key you need to provide all 3 of:

  • Address
  • Public Key
  • Partial Address

These should be required options
@PhilWindle PhilWindle added this to A3 Aug 11, 2023
@PhilWindle PhilWindle converted this from a draft issue Aug 11, 2023
@iAmMichaelConnor iAmMichaelConnor added the A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) label Aug 14, 2023
@iAmMichaelConnor iAmMichaelConnor mentioned this issue Aug 16, 2023
Closed
9 tasks
@benesjan benesjan self-assigned this Aug 16, 2023
@benesjan benesjan moved this from Todo to In Progress in A3 Aug 16, 2023
@benesjan benesjan mentioned this issue Aug 16, 2023
Merged
4 tasks
@benesjan benesjan moved this from In Progress to In Review in A3 Aug 16, 2023
benesjan added a commit that referenced this issue Aug 16, 2023
@benesjan
refactor: required option in aztec-cli (#1584)
f287416 
Fixes #1520
+ fixes broken yarn start in CLI
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Aug 16, 2023
codygunton pushed a commit that referenced this issue Jan 23, 2024
@charlielye
Merge pull request #1520 from AztecProtocol/v2.1-testnet
1f247e5 
Merge back hotfixes from testnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex)
Projects
A3
Archived in project
Milestone
🚀 Initial F&F Sandbox Release
Development

Successfully merging a pull request may close this issue.

refactor: required option in aztec-cli AztecProtocol/aztec-packages
3 participants
@benesjan @iAmMichaelConnor @PhilWindle