Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deployment of Aztec Sandbox npm package #1536

Closed
PhilWindle opened this issue Aug 11, 2023 · 0 comments · Fixed by #1593
Closed

Fix deployment of Aztec Sandbox npm package #1536

PhilWindle opened this issue Aug 11, 2023 · 0 comments · Fixed by #1593
Assignees
@spalladino
Labels
T-bug Type: Bug. Something is broken.
Milestone
🚀 Initial F&F San...

Comments

@PhilWindle
Copy link
Collaborator

PhilWindle commented Aug 11, 2023 •
edited
Loading

We are currently not deploying sufficient dependencies to npm in order to use the sandbox directly as an npm package. We need to update the circle ci config for this.
@PhilWindle PhilWindle added this to A3 Aug 11, 2023
@PhilWindle PhilWindle converted this from a draft issue Aug 11, 2023
@iAmMichaelConnor iAmMichaelConnor added the T-bug Type: Bug. Something is broken. label Aug 14, 2023
@spalladino spalladino mentioned this issue Aug 14, 2023
Closed
@spalladino spalladino self-assigned this Aug 16, 2023
@spalladino spalladino moved this from Todo to In Review in A3 Aug 16, 2023
@spalladino spalladino mentioned this issue Aug 16, 2023
Merged
spalladino added a commit that referenced this issue Aug 16, 2023
@spalladino
chore(ci): Deploy sandbox dependencies to npm (#1593)
d90c460 
We were publishing `aztec-sandbox` to npm, but were missing many of its
dependencies. This adds them manually to the CI script. Eventually, it'd
be nice to migrate to a tool that handles this automatically (@ludamad
another feature request for a monorepo tool, if we go with one).

Also, bear in mind this still is untested, since I need to tag to test,
and I don't want to tag a commit not on master.

Fixes #1536
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalladino spalladino

Labels
T-bug Type: Bug. Something is broken.
Projects
A3
Archived in project
Milestone
🚀 Initial F&F Sandbox Release
Development

Successfully merging a pull request may close this issue.

chore(ci): Deploy sandbox dependencies to npm AztecProtocol/aztec-packages
3 participants
@spalladino @iAmMichaelConnor @PhilWindle