Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Reenable uniswap e2e tests #1367

Closed
ludamad opened this issue Aug 2, 2023 · 3 comments · Fixed by #1399
Closed

[ci] Reenable uniswap e2e tests #1367

ludamad opened this issue Aug 2, 2023 · 3 comments · Fixed by #1399
Labels
A-devops Area: Devops. E.g. CI / build systems

Comments

@ludamad
Copy link
Collaborator

ludamad commented Aug 2, 2023 •
edited
Loading

Seem to be rate limited or something. Would be good to minimize reliance on infura (minimizing our API rate limits is probably important as CI might become really active at points)

EDIT: May be temporary outage, see below, likely just waiting
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 2, 2023
ludamad added a commit that referenced this issue Aug 2, 2023
@ludamad
fix: disable uniswap until #1367
9de13ad
@ludamad ludamad mentioned this issue Aug 2, 2023
Merged
ludamad added a commit that referenced this issue Aug 2, 2023
@ludamad
fix: disable uniswap until #1367
50049fe
ludamad added a commit that referenced this issue Aug 2, 2023
@ludamad
fix: disable uniswap until #1367 (#1368)
7a1c4f7 
This is currently unstable. See #1367
@ludamad ludamad added the A-devops Area: Devops. E.g. CI / build systems label Aug 2, 2023
@LHerskind
Copy link
Contributor

Maybe possible to do like https://github.com/PaulRBerg/foundry-template/blob/main/.github/workflows/ci.yml.

@ludamad
Copy link
Collaborator Author

ludamad commented Aug 2, 2023

Interesting what's this FOUNDRY_FUZZ_SEED voodoo?

@ludamad
Copy link
Collaborator Author

ludamad commented Aug 2, 2023

image
Screenshot 2023-08-02 at 9 37 53 AM

@ludamad ludamad changed the title [ci] Stabilize uniswap e2e tests [ci] Reenable uniswap e2e tests Aug 2, 2023
@ludamad ludamad mentioned this issue Aug 3, 2023
Merged
4 tasks
LHerskind added a commit that referenced this issue Aug 4, 2023
@LHerskind
fix: Used dumped state instead of fork (#1399)
c265e73 
Fixes #1367

Use a chain dump instead of forking for uniswap tests.

The sandbox is still using the fork.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-devops Area: Devops. E.g. CI / build systems
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Used dumped state instead of fork AztecProtocol/aztec-packages
2 participants
@ludamad @LHerskind