Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CheatCode): loadPrivate(who, slot) #1285

Closed
Tracked by #1259
LHerskind opened this issue Jul 31, 2023 · 2 comments · Fixed by #3243 or #3266
Closed
Tracked by #1259

feat(CheatCode): loadPrivate(who, slot) #1285

LHerskind opened this issue Jul 31, 2023 · 2 comments · Fixed by #3243 or #3266
Assignees
@rahul-kothari
Labels
A-internal-devex Area: Relates to the devex of internal teams building Aztec.

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Jul 31, 2023 •
edited
Loading

Allows the dev to load the PREIMAGE values they know of for a storage slot in private data.

Already supported at the node, so just needs to be exposed in cheatcodes.
@LHerskind LHerskind mentioned this issue Jul 31, 2023
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 31, 2023
@LHerskind LHerskind changed the title loadPrivate(who, slot) - loads the preimage value(s) and for the storage slot (we have this in the node) feat(CheatCode): loadPrivate(who, slot) Jul 31, 2023
@LHerskind LHerskind added the A-internal-devex Area: Relates to the devex of internal teams building Aztec. label Aug 9, 2023
@LHerskind LHerskind mentioned this issue Aug 11, 2023
Merged
4 tasks
@rahul-kothari
Copy link
Contributor

rahul-kothari commented Aug 11, 2023 •
edited
Loading

RPC Server removed their function getPreimagesAt - 7e14e7b

The private state info is in MemoryDB whose access is only in AztecRPC (and not AztecNode) and Phil/Jan believe it shouldn't be exposed anymore - see #1420 (comment). Since it isn't absolutely crucial for the sandbox release let's come back to this later, perhaps when we have come up good authentication systems.

@rahul-kothari rahul-kothari moved this from Todo to Blocked in A3 Aug 14, 2023
@LHerskind
Copy link
Contributor Author

This was added in #1992 when function was re-added to PXE. Only needs the docs to be added. @rahul-kothari will you add the docs since this is now unblocked.

@LHerskind LHerskind moved this from Blocked to In Progress in A3 Oct 12, 2023
@LHerskind LHerskind moved this from In Progress to Todo in A3 Oct 12, 2023
@rahul-kothari rahul-kothari mentioned this issue Nov 6, 2023
Merged
rahul-kothari added a commit that referenced this issue Nov 7, 2023
@rahul-kothari
feat: load private tests and docs (#3243)
f3d8aae 
Fix #1285
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Nov 7, 2023
@AztecBot AztecBot mentioned this issue Nov 7, 2023
Merged
rahul-kothari pushed a commit that referenced this issue Nov 7, 2023
@AztecBot
chore(master): Release 0.14.2 (#3266)
2da5feb 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.14.2</summary>

##
[0.14.2](aztec-packages-v0.14.1...aztec-packages-v0.14.2)
(2023-11-07)


### Features

* Load private tests and docs
([#3243](#3243))
([f3d8aae](f3d8aae)),
closes
[#1285](#1285)
* Run solidity tests for all acir artifacts
([#3161](#3161))
([d09f667](d09f667))


### Bug Fixes

* Wait for accounts to catch up with notes when deployed
([#2834](#2834))
([a8f3119](a8f3119))


### Miscellaneous

* Add noir-protocol-circuits to deploy_npm
([#3268](#3268))
([1a22cae](1a22cae))
* Aztec-cli better volume mounting strategy
([#3138](#3138))
([d40460e](d40460e))
* Disable circuits tasks
([#3253](#3253))
([e8945f8](e8945f8))
</details>

<details><summary>barretenberg.js: 0.14.2</summary>

##
[0.14.2](barretenberg.js-v0.14.1...barretenberg.js-v0.14.2)
(2023-11-07)


### Features

* Run solidity tests for all acir artifacts
([#3161](#3161))
([d09f667](d09f667))
</details>

<details><summary>barretenberg: 0.14.2</summary>

##
[0.14.2](barretenberg-v0.14.1...barretenberg-v0.14.2)
(2023-11-07)


### Features

* Run solidity tests for all acir artifacts
([#3161](#3161))
([d09f667](d09f667))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this issue Nov 8, 2023
@AztecBot
chore(master): Release 0.14.2 (#3266)
c223a22 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.14.2</summary>

##
[0.14.2](AztecProtocol/aztec-packages@aztec-packages-v0.14.1...aztec-packages-v0.14.2)
(2023-11-07)


### Features

* Load private tests and docs
([#3243](AztecProtocol/aztec-packages#3243))
([f3d8aae](AztecProtocol/aztec-packages@f3d8aae)),
closes
[#1285](AztecProtocol/aztec-packages#1285)
* Run solidity tests for all acir artifacts
([#3161](AztecProtocol/aztec-packages#3161))
([d09f667](AztecProtocol/aztec-packages@d09f667))


### Bug Fixes

* Wait for accounts to catch up with notes when deployed
([#2834](AztecProtocol/aztec-packages#2834))
([a8f3119](AztecProtocol/aztec-packages@a8f3119))


### Miscellaneous

* Add noir-protocol-circuits to deploy_npm
([#3268](AztecProtocol/aztec-packages#3268))
([1a22cae](AztecProtocol/aztec-packages@1a22cae))
* Aztec-cli better volume mounting strategy
([#3138](AztecProtocol/aztec-packages#3138))
([d40460e](AztecProtocol/aztec-packages@d40460e))
* Disable circuits tasks
([#3253](AztecProtocol/aztec-packages#3253))
([e8945f8](AztecProtocol/aztec-packages@e8945f8))
</details>

<details><summary>barretenberg.js: 0.14.2</summary>

##
[0.14.2](AztecProtocol/aztec-packages@barretenberg.js-v0.14.1...barretenberg.js-v0.14.2)
(2023-11-07)


### Features

* Run solidity tests for all acir artifacts
([#3161](AztecProtocol/aztec-packages#3161))
([d09f667](AztecProtocol/aztec-packages@d09f667))
</details>

<details><summary>barretenberg: 0.14.2</summary>

##
[0.14.2](AztecProtocol/aztec-packages@barretenberg-v0.14.1...barretenberg-v0.14.2)
(2023-11-07)


### Features

* Run solidity tests for all acir artifacts
([#3161](AztecProtocol/aztec-packages#3161))
([d09f667](AztecProtocol/aztec-packages@d09f667))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
codygunton pushed a commit that referenced this issue Jan 23, 2024
@arijitdutta67
Update Aztec Connect Specs after Launch (#1285)
3df798b 
* removing allow_zero_input and fixing latex rendering

* Fixing latex rendering

* minor changes

* Claim circuit spec is updated and diagram is changed

* removing claim circuit unintentional change

* removing claim circuit unintentional change

* minor change as per Ariel suggestion

* Reverting claim circuit example

* minor changes to rollup md

* cleanup and Mike suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul-kothari rahul-kothari

Labels
A-internal-devex Area: Relates to the devex of internal teams building Aztec.
Projects
A3
Archived in project
Milestone
No milestone
2 participants
@LHerskind @rahul-kothari