Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't retransmit txs upon node restart #11123

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

PhilWindle
Copy link
Collaborator

@PhilWindle PhilWindle commented Jan 9, 2025

A long time ago, the node was written such that it would broadcast all txs in it's pool after a restart. This seems unnecessary now and can cause lib-p2p errors when it does so. Removed.

@PhilWindle PhilWindle added the e2e-p2p CI: Enables this CI job. label Jan 9, 2025
@PhilWindle PhilWindle linked an issue Jan 9, 2025 that may be closed by this pull request
@PhilWindle PhilWindle merged commit 39535c9 into master Jan 9, 2025
55 checks passed
@PhilWindle PhilWindle deleted the pw/stop-resends branch January 9, 2025 13:15
TomAFrench added a commit that referenced this pull request Jan 9, 2025
* master: (287 commits)
  feat: Sync from noir (#11051)
  chore(docs): Update tx concepts page (#10947)
  chore(docs): Edit Aztec.nr Guide section (#10866)
  chore: test:e2e defaults to no-docker (#10966)
  chore(avm): improve column stats (#11135)
  chore: Sanity checking of proving job IDs (#11134)
  feat: permutation argument optimizations  (#10960)
  feat: single tx block root rollup (#11096)
  refactor: prover db config (#11126)
  feat: monitor event loop lag (#11127)
  chore: Greater stability at 1TPS (#10981)
  chore: Jest reporters for CI (#11125)
  fix: Sequencer times out L1 tx at end of L2 slot (#11112)
  feat: browser chunking (#11102)
  fix: Added start/stop guards to running promise and serial queue (#11120)
  fix: Don't retransmit txs upon node restart (#11123)
  fix: Prover node aborts execution at epoch end (#11111)
  feat: blob sink in sandbox without extra process (#11032)
  chore: log number of instructions executed for call in AVM. Misc fix. (#11110)
  git subrepo push --branch=master noir-projects/aztec-nr
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-p2p CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2P Don't re-transmit all txs on restart
2 participants