Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test:e2e defaults to no-docker #10966

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

spalladino
Copy link
Collaborator

Since we run this more often locally, default to no-docker.

@ludamad
Copy link
Collaborator

ludamad commented Dec 24, 2024

Makes sense to me, just will need to update the ways this is called in the bootstrap scripts etc

@spalladino
Copy link
Collaborator Author

I found no reference to test:e2e in any script.

@ludamad
Copy link
Collaborator

ludamad commented Dec 24, 2024

Not at computer but I did use e2e-no-docker for testing the e2e in ci

@spalladino spalladino force-pushed the palla/no-docker-is-default branch from 6e58cf8 to 3242949 Compare January 9, 2025 13:24
Since we run this more often locally, default to no-docker.
@spalladino spalladino force-pushed the palla/no-docker-is-default branch from 3242949 to 9046dc5 Compare January 9, 2025 19:29
@spalladino spalladino enabled auto-merge (squash) January 9, 2025 19:30
@spalladino spalladino merged commit 15e0d71 into master Jan 9, 2025
47 checks passed
@spalladino spalladino deleted the palla/no-docker-is-default branch January 9, 2025 20:00
TomAFrench added a commit that referenced this pull request Jan 9, 2025
* master: (287 commits)
  feat: Sync from noir (#11051)
  chore(docs): Update tx concepts page (#10947)
  chore(docs): Edit Aztec.nr Guide section (#10866)
  chore: test:e2e defaults to no-docker (#10966)
  chore(avm): improve column stats (#11135)
  chore: Sanity checking of proving job IDs (#11134)
  feat: permutation argument optimizations  (#10960)
  feat: single tx block root rollup (#11096)
  refactor: prover db config (#11126)
  feat: monitor event loop lag (#11127)
  chore: Greater stability at 1TPS (#10981)
  chore: Jest reporters for CI (#11125)
  fix: Sequencer times out L1 tx at end of L2 slot (#11112)
  feat: browser chunking (#11102)
  fix: Added start/stop guards to running promise and serial queue (#11120)
  fix: Don't retransmit txs upon node restart (#11123)
  fix: Prover node aborts execution at epoch end (#11111)
  feat: blob sink in sandbox without extra process (#11032)
  chore: log number of instructions executed for call in AVM. Misc fix. (#11110)
  git subrepo push --branch=master noir-projects/aztec-nr
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants