Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordering circuit's public inputs should not include read requests #1074

Closed
Tracked by #1064
dbanks12 opened this issue Jul 14, 2023 · 1 comment · Fixed by #1840
Closed
Tracked by #1064

Ordering circuit's public inputs should not include read requests #1074

dbanks12 opened this issue Jul 14, 2023 · 1 comment · Fixed by #1840
Assignees
@jeanmon
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)

Comments

@dbanks12
Copy link
Collaborator

No description provided.

@dbanks12 dbanks12 added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Jul 14, 2023
@dbanks12 dbanks12 added this to A3 Jul 14, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 14, 2023
This was referenced Jul 14, 2023
Merged
Closed
@dbanks12
Copy link
Collaborator Author

Might need a second version of CombinedAccumulatedData like FinalAccumulatedData and put that in a new struct KernelCircuitPublicInputsFinal

@jeanmon jeanmon self-assigned this Aug 28, 2023
@jeanmon jeanmon moved this from Todo to In Progress in A3 Aug 28, 2023
@jeanmon jeanmon mentioned this issue Aug 28, 2023
Merged
4 tasks
@jeanmon jeanmon moved this from In Progress to In Review in A3 Aug 30, 2023
jeanmon added a commit that referenced this issue Aug 30, 2023
@jeanmon
chore(1074): remove read request data from final private kernel circu…
c61557a 
…it public inputs (#1840)

Resolves #1074

Refactor task consisting in defining a specific struct for the public
inputs of final ordering private kernel circuit. This new struct is
named: KernelCircuitPublicInputsFinal
This struct is identical to KernelCircuitPublicInputs except that we
trimmed the 4 following members from CombinedAccumulatedData (a struct
named FinalAccumulatedData was introduced for this purpose):

- read_requests
- read_request_membership_witnesses
- public_data_update_requests
- public_data_reads

In addition, one commit which resolves #1865 was added.


# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [x] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
A3
Archived in project
Milestone
No milestone
2 participants
@dbanks12 @jeanmon