Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider re-expanding prover-client-test #10678

Open
ludamad opened this issue Dec 13, 2024 · 1 comment
Open

Consider re-expanding prover-client-test #10678

ludamad opened this issue Dec 13, 2024 · 1 comment
Labels
T-testing Type: Testing. More tests need to be added. team-alpha

Comments

@ludamad
Copy link
Collaborator

ludamad commented Dec 13, 2024 •
edited
Loading

at the moment yarn-project/prover-client/src/test/bb_prover_full_rollup.test.ts has only a one block epoch test, the rest disabled due to resources and time. If core proving time goes down a lot, or we are able to refactor this somehow to use less proving, we can reconsider. Otherwise, it can be a nightly test
@ludamad ludamad mentioned this issue Dec 13, 2024
Merged
@ludamad ludamad changed the title Reconsider re-expanding prover-client-test Consider re-expanding prover-client-test Dec 13, 2024
@ludamad ludamad added team-alpha T-testing Type: Testing. More tests need to be added. labels Dec 13, 2024
ludamad added a commit that referenced this issue Dec 13, 2024
@ludamad
chore: reduce bb_prover_full_rollup to a single block epoch test (#10679
0c2a4d9 
)

This reduces CI burden on the main runner as proving times have gone up
a lot. This should happen outside of PRs otherwise, e.g. nightly
Related #10678
@MirandaWood
Copy link
Contributor

Just FYI the disabled two block iteration of this test is required to fill the fixture used in yarn-project/end-to-end/src/composed/integration_proof_verification.test.ts. I'm not sure the verification test is currently used (but it works on my branch with an updated fixture).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-testing Type: Testing. More tests need to be added. team-alpha
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ludamad @MirandaWood