Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and re-enable e2e uniswap test #10030

Closed
PhilWindle opened this issue Nov 19, 2024 · 0 comments · Fixed by #10214
Closed

Fix and re-enable e2e uniswap test #10030

PhilWindle opened this issue Nov 19, 2024 · 0 comments · Fixed by #10214

Comments

@PhilWindle
Copy link
Collaborator

No description provided.

lucasxia01 pushed a commit that referenced this issue Dec 11, 2024
…ow 20k. (#10214)

Resolves #10030

Bump of AVM startup gas to 20k is mostly arbitrary, but considering some
individual opcodes cost more than its previous value of 512, it
certainly needed to be much higher. I thought 20k is at least _more_
reasonable to account for the constraint cost of verifying an AVM proof.

The l2 gas maximum per-tx-public-portion ensures that there is some hard
limit on execution per AVM proof. For now, we use that limit to ensure
that you cannot overflow the AVM trace.

---------

Co-authored-by: IlyasRidhuan <[email protected]>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Dec 12, 2024
…ow 20k. (#10214)

Resolves AztecProtocol/aztec-packages#10030

Bump of AVM startup gas to 20k is mostly arbitrary, but considering some
individual opcodes cost more than its previous value of 512, it
certainly needed to be much higher. I thought 20k is at least _more_
reasonable to account for the constraint cost of verifying an AVM proof.

The l2 gas maximum per-tx-public-portion ensures that there is some hard
limit on execution per AVM proof. For now, we use that limit to ensure
that you cannot overflow the AVM trace.

---------

Co-authored-by: IlyasRidhuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant