Skip to content

Commit

Permalink
typos + make gcc pass
Browse files Browse the repository at this point in the history
  • Loading branch information
maramihali committed Feb 20, 2024
1 parent 5a75ea3 commit fe13bc1
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ class IvcBench : public benchmark::Fixture {
Builder initial_function_circuit{ ivc.goblin.op_queue };
GoblinMockCircuits::construct_mock_function_circuit(initial_function_circuit);
ivc.initialize(initial_function_circuit);
auto kernel_verifeir_accumulator = std::make_shared<ClientIVC::VerifierInstance>();
kernel_verifeir_accumulator->verification_key = ivc.vks.first_func_vk;
auto kernel_verifier_accumulator = std::make_shared<ClientIVC::VerifierInstance>();
kernel_verifier_accumulator->verification_key = ivc.vks.first_func_vk;

// Accumulate another function circuit
Builder function_circuit{ ivc.goblin.op_queue };
Expand All @@ -59,8 +59,8 @@ class IvcBench : public benchmark::Fixture {

// Create and accumulate the first folding kernel which only verifies the accumulation of a function circuit
Builder kernel_circuit{ ivc.goblin.op_queue };
kernel_verifeir_accumulator = GoblinMockCircuits::construct_mock_folding_kernel(
kernel_circuit, function_fold_output, {}, kernel_verifeir_accumulator);
kernel_verifier_accumulator = GoblinMockCircuits::construct_mock_folding_kernel(
kernel_circuit, function_fold_output, {}, kernel_verifier_accumulator);
auto kernel_fold_proof = ivc.accumulate(kernel_circuit);
FoldOutput kernel_fold_output = { kernel_fold_proof, ivc.vks.first_kernel_vk };

Expand All @@ -77,8 +77,8 @@ class IvcBench : public benchmark::Fixture {
// Create kernel circuit containing the recursive folding verification of a function circuit and a kernel
// circuit and accumulate it
Builder kernel_circuit{ ivc.goblin.op_queue };
kernel_verifeir_accumulator = GoblinMockCircuits::construct_mock_folding_kernel(
kernel_circuit, function_fold_output, kernel_fold_output, kernel_verifeir_accumulator);
kernel_verifier_accumulator = GoblinMockCircuits::construct_mock_folding_kernel(
kernel_circuit, function_fold_output, kernel_fold_output, kernel_verifier_accumulator);

kernel_fold_proof = ivc.accumulate(kernel_circuit);
kernel_fold_output = { kernel_fold_proof, ivc.vks.kernel_vk };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ TEST_F(MockKernelTest, PinFoldingKernelSizes)
using FoldOutput = GoblinMockCircuits::FoldOutput;
ClientIVC ivc;
ivc.precompute_folding_verification_keys();
// Accumulate three circuits to generate two folding proofs for input to foldng kernel
// Accumulate three circuits to generate two folding proofs for input to folding kernel
GoblinUltraCircuitBuilder circuit_1{ ivc.goblin.op_queue };
GoblinMockCircuits::construct_mock_function_circuit(circuit_1);
ivc.initialize(circuit_1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ std::shared_ptr<typename Flavor::VerificationKey> UltraComposer_<Flavor>::comput
verification_key->q_poseidon2_internal = commitment_key->commit(proving_key->q_poseidon2_internal);
}

return std::move(verification_key);
return verification_key;
}

template <IsUltraFlavor Flavor>
Expand Down

0 comments on commit fe13bc1

Please sign in to comment.