Skip to content

Commit

Permalink
fix: noir contract artifacts generation in CI (#1366)
Browse files Browse the repository at this point in the history
# Description

In CI we used stale build of contract types because we failed to build
them after generating them. This was causing issues when there was a
change which required re-generating these types. This PR fixes this.

See [this PR](#1365)
for proof that that was the issue.
  • Loading branch information
benesjan authored Aug 2, 2023
1 parent 448f48f commit f715a55
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions yarn-project/yarn-project-base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,11 @@ COPY . .
COPY --from=noir /usr/src/yarn-project/noir-contracts/src/contracts /usr/src/yarn-project/noir-contracts/src/contracts
WORKDIR /usr/src/yarn-project/noir-contracts

# Run yarn build to have the json ABIs available for the types generator
RUN yarn build
RUN ./scripts/types_ci.sh
# Run yarn build again to build the types
RUN yarn build

# Take noir contract artifacts into the final build image
FROM builder_ as final
Expand Down

0 comments on commit f715a55

Please sign in to comment.