link issues properly

AztecProtocol · Oct 7, 2023 · e358648 · e358648
1 parent d94de65
commit e358648
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 11 deletions.
diff --git a/barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy.test.cpp b/barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy.test.cpp
@@ -17,7 +17,8 @@ namespace protogalaxy_utils_tests {
 namespace {
 auto& engine = numeric::random::get_debug_engine();
 }
-
+// TODO(https://github.com/AztecProtocol/barretenberg/issues/744): make testing utility with functionality shared
+// amongst test files in the proof system
 barretenberg::Polynomial<FF> get_random_polynomial(size_t size)
 {
     auto poly = barretenberg::Polynomial<FF>(size);

diff --git a/barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_prover.cpp b/barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_prover.cpp
@@ -37,12 +37,13 @@ template <class ProverInstances> void ProtoGalaxyProver_<ProverInstances>::prepa
     }
 }
 
-// TODO(#689): finalise implementation this function
+// TODO(#https://github.com/AztecProtocol/barretenberg/issues/689): finalise implementation this function
 template <class ProverInstances>
 ProverFoldingResult<typename ProverInstances::Flavor> ProtoGalaxyProver_<ProverInstances>::fold_instances()
 {
     prepare_for_folding();
-    // TODO(#740): Handle the case where we are folding for the first time and accumulator is 0
+    // TODO(#https://github.com/AztecProtocol/barretenberg/issues/740): Handle the case where we are folding for the
+    // first time and accumulator is 0
     auto [alpha, delta] = transcript.get_challenges("alpha", "delta");
     auto accumulator = get_accumulator();
     auto instance_size = accumulator->prover_polynomials[0].size();

diff --git a/barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_prover.hpp b/barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_prover.hpp
@@ -123,7 +123,8 @@ template <class ProverInstances> class ProtoGalaxyProver_ {
      * the tree, label the branch connecting the left node n_l to its parent by 1 and for the right node n_r by β_i +
      * δ_i X. The value of the parent node n will be constructed as n = n_l + n_r * (β_i + δ_i X). Recurse over each
      * layer until the root is reached which will correspond to the perturbator polynomial F(X).
-     * TODO(insert issue): make this more memory efficient
+     * TODO(https://github.com/AztecProtocol/barretenberg/issues/745): make computation of perturbator more memory
+     * efficient
      */
     static std::vector<FF> construct_perturbator_coeffs(std::vector<FF> betas,
                                                         std::vector<FF> deltas,
@@ -146,14 +147,10 @@ template <class ProverInstances> class ProtoGalaxyProver_ {
      */
     static Polynomial<FF> compute_perturbator(std::shared_ptr<Instance> accumulator, std::vector<FF> deltas, FF alpha)
     {
-        auto instance_size = accumulator->prover_polynomials[0].size();
-        auto const log_instance_size = static_cast<size_t>(numeric::get_msb(instance_size));
-        assert(deltas.size() == log_instance_size);
         auto full_honk_evaluations =
             compute_full_honk_evaluations(accumulator->prover_polynomials, alpha, accumulator->relation_parameters);
-        info("evals from compute", full_honk_evaluations);
         auto betas = accumulator->folding_params.gate_separation_challenges;
-        assert(betas.size() == log_instance_size);
+        assert(betas.size() == deltas.size());
         auto coeffs = construct_perturbator_coeffs(betas, deltas, full_honk_evaluations);
         return Polynomial<FF>(coeffs);
     }

diff --git a/barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_verifier.cpp b/barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_verifier.cpp
@@ -40,7 +40,7 @@ VerifierFoldingResult<typename VerifierInstances::Flavor> ProtoGalaxyVerifier_<
         perturbator[idx] = transcript.template receive_from_prover<FF>("perturbator_" + std::to_string(idx));
     }
 
-    // TODO(#690): implement the  Protogalaxy verifier logic
+    // TODO(https://github.com/AztecProtocol/barretenberg/issues/690): finalise the  Protogalaxy verifier logic
     VerifierFoldingResult<Flavor> res;
     return res;
 }

diff --git a/barretenberg/cpp/src/barretenberg/polynomials/pow.hpp b/barretenberg/cpp/src/barretenberg/polynomials/pow.hpp
@@ -90,7 +90,6 @@ namespace barretenberg {
  *             = pow(u_{0}, ..., u_{d-1})                           // Full evaluation of pow
  * - σ_{ d } =?= c_{d}⋅P(u_{0}, ..., u_{d-1})                       // Compare against real evaluation of P'(u)
  */
-// this can be used to compute deltas for each round as it is
 template <typename FF> struct PowUnivariate {
     // ζ_{l}, initialized as ζ_{0} = ζ
     // At round l, equals ζ^{ 2^l }