fix(build-system): undefined IMAGE_TAG and ARG_TAG (#2030)

AztecProtocol · Sep 5, 2023 · dfdba4b · dfdba4b
1 parent a0ccd4a
commit dfdba4b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/build-system/scripts/deploy_dockerhub b/build-system/scripts/deploy_dockerhub
@@ -7,6 +7,7 @@ if [ -z "$COMMIT_TAG" ]; then
 fi
 
 REPOSITORY=$1
+IMAGE_TAG=$COMMIT_TAG_VERSION
 IMAGE_COMMIT_URI=$ECR_DEPLOY_URL/$REPOSITORY:$COMMIT_HASH
 IMAGE_DEPLOY_URI=aztecprotocol/$REPOSITORY:$IMAGE_TAG
 IMAGE_LATEST_URI=aztecprotocol/$REPOSITORY:latest
@@ -34,9 +35,6 @@ if [ -z "$VERSION" ]; then
   exit 1
 fi
 
-IMAGE_TAG=$COMMIT_TAG_VERSION
-
-
 echo "Deploying to dockerhub: $IMAGE_DEPLOY_URI"
 
 # Login.

diff --git a/build-system/scripts/deploy_npm b/build-system/scripts/deploy_npm
@@ -42,7 +42,7 @@ if [ -n "$TAG" ]; then
   TAG_ARG="--tag $TAG"
 fi
 
-readonly PUBLISHED_VERSION=$(npm show . version $TAG_ARG 2> /dev/null)
+readonly PUBLISHED_VERSION=$(npm show . version ${TAG_ARG:-} 2> /dev/null)
 readonly HIGHER_VERSION=$(npx semver ${VERSION} ${PUBLISHED_VERSION} | tail -1)
 
 # If there is already a published package equal to given version, assume this is a re-run of a deploy, and early out.