Store ECDSA public key in private note in account contract and refact…

…or (#1054)

* Store ECDSA public key in private note in account contract

* Default sender to wallet address instead of zero

* Fix undefined salt not being overridden with a random value

* Enable address check in Schnorr account

* Refactor account tests and enable them for Schnorr account

* Refactor Schnorr account contract

* Add AccountImpl for ECDSA and setup e2e test

* Pick up e2e account contracts in CI after rename and skip ecdsa test

* Update account contracts after rebase

* Copy account contracts ABI to aztec-js to avoid dependency on noir-contracts

.circleci/config.yml

@@ -515,7 +515,7 @@ jobs:
       - *setup_env
       - run:
           name: "Test"
-          command: cond_spot_run_tests end-to-end e2e_account_contract.test.ts
+          command: cond_spot_run_tests end-to-end e2e_account_contracts.test.ts
 
   e2e-pending-commitments-contract:
     docker:

yarn-project/aztec.js/src/abis/ecdsa_account_contract.json

@@ -0,0 +1,103 @@
+{
+  "name": "EcdsaAccount",
+  "functions": [
+    {
+      "name": "constructor",
+      "functionType": "secret",
+      "parameters": [
+        {
+          "name": "signing_pub_key_x",
+          "type": {
+            "kind": "array",
+            "length": 32,
+            "type": {
+              "kind": "integer",
+              "sign": "unsigned",
+              "width": 8
+            }
+          },
+          "visibility": "public"
+        },
+        {
+          "name": "signing_pub_key_y",
+          "type": {
+            "kind": "array",
+            "length": 32,
+            "type": {
+              "kind": "integer",
+              "sign": "unsigned",
+              "width": 8
+            }
+          },
+          "visibility": "public"
+        }
+      ],
+      "returnTypes": []
+    },
+    {
+      "name": "entrypoint",
+      "functionType": "secret",
+      "parameters": [
+        {
+          "name": "payload",
+          "type": {
+            "kind": "struct",
+            "fields": [
+              {
+                "name": "flattened_args_hashes",
+                "type": {
+                  "kind": "array",
+                  "length": 2,
+                  "type": {
+                    "kind": "field"
+                  }
+                }
+              },
+              {
+                "name": "flattened_selectors",
+                "type": {
+                  "kind": "array",
+                  "length": 2,
+                  "type": {
+                    "kind": "field"
+                  }
+                }
+              },
+              {
+                "name": "flattened_targets",
+                "type": {
+                  "kind": "array",
+                  "length": 2,
+                  "type": {
+                    "kind": "field"
+                  }
+                }
+              },
+              {
+                "name": "nonce",
+                "type": {
+                  "kind": "field"
+                }
+              }
+            ]
+          },
+          "visibility": "public"
+        },
+        {
+          "name": "signature",
+          "type": {
+            "kind": "array",
+            "length": 64,
+            "type": {
+              "kind": "integer",
+              "sign": "unsigned",
+              "width": 8
+            }
+          },
+          "visibility": "public"
+        }
+      ],
+      "returnTypes": []
+    }
+  ]
+}

yarn-project/aztec.js/src/abis/schnorr_account_contract.json

@@ -0,0 +1,96 @@
+{
+  "name": "SchnorrAccount",
+  "functions": [
+    {
+      "name": "constructor",
+      "functionType": "secret",
+      "parameters": [],
+      "returnTypes": []
+    },
+    {
+      "name": "entrypoint",
+      "functionType": "secret",
+      "parameters": [
+        {
+          "name": "payload",
+          "type": {
+            "kind": "struct",
+            "fields": [
+              {
+                "name": "flattened_args_hashes",
+                "type": {
+                  "kind": "array",
+                  "length": 2,
+                  "type": {
+                    "kind": "field"
+                  }
+                }
+              },
+              {
+                "name": "flattened_selectors",
+                "type": {
+                  "kind": "array",
+                  "length": 2,
+                  "type": {
+                    "kind": "field"
+                  }
+                }
+              },
+              {
+                "name": "flattened_targets",
+                "type": {
+                  "kind": "array",
+                  "length": 2,
+                  "type": {
+                    "kind": "field"
+                  }
+                }
+              },
+              {
+                "name": "nonce",
+                "type": {
+                  "kind": "field"
+                }
+              }
+            ]
+          },
+          "visibility": "public"
+        },
+        {
+          "name": "owner",
+          "type": {
+            "kind": "array",
+            "length": 64,
+            "type": {
+              "kind": "integer",
+              "sign": "unsigned",
+              "width": 8
+            }
+          },
+          "visibility": "public"
+        },
+        {
+          "name": "signature",
+          "type": {
+            "kind": "array",
+            "length": 64,
+            "type": {
+              "kind": "integer",
+              "sign": "unsigned",
+              "width": 8
+            }
+          },
+          "visibility": "public"
+        },
+        {
+          "name": "partial_address",
+          "type": {
+            "kind": "field"
+          },
+          "visibility": "public"
+        }
+      ],
+      "returnTypes": []
+    }
+  ]
+}