Skip to content

Commit

Permalink
chore: Don't generate proofs of verifier circuits in test (#10405)
Browse files Browse the repository at this point in the history
To test circuit logic we don't need to generate proofs. Running the
circuit checker is much faster and more memory efficient.
  • Loading branch information
codygunton authored Dec 5, 2024
1 parent e1e5906 commit c00ebdd
Showing 1 changed file with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -345,14 +345,8 @@ template <typename OuterComposer> class stdlib_verifier : public testing::Test {
static void check_recursive_verification_circuit(OuterBuilder& outer_circuit, bool expected_result)
{
info("number of gates in recursive verification circuit = ", outer_circuit.get_estimated_num_finalized_gates());
OuterComposer outer_composer;
auto prover = outer_composer.create_prover(outer_circuit);
auto verifier = outer_composer.create_verifier(outer_circuit);
auto proof = prover.construct_proof();
auto result = verifier.verify_proof(proof);
// bool result = CircuitChecker::check(outer_circuit);
const bool result = CircuitChecker::check(outer_circuit);
EXPECT_EQ(result, expected_result);
static_cast<void>(expected_result);
auto g2_lines = srs::get_bn254_crs_factory()->get_verifier_crs()->get_precomputed_g2_lines();
EXPECT_EQ(check_pairing_point_accum_public_inputs(outer_circuit, g2_lines), true);
}
Expand Down

1 comment on commit c00ebdd

@AztecBot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: c00ebdd Previous: 7ed89aa Ratio
nativeconstruct_proof_ultrahonk_power_of_2/20 5112.618403999988 ms/iter 4626.7122279999885 ms/iter 1.11
Goblin::merge(t) 147869487 ns/iter 136619531 ns/iter 1.08

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

Please sign in to comment.