Skip to content

Commit

Permalink
fix: clean up old comments
Browse files Browse the repository at this point in the history
  • Loading branch information
IlyasRidhuan committed Dec 6, 2024
1 parent 49d4b35 commit a2d556c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
15 changes: 0 additions & 15 deletions barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3465,7 +3465,6 @@ AvmError AvmTraceBuilder::constrain_external_call(OpCode opcode,
// We keep the first encountered error
AvmError error = AvmError::NO_ERROR;
auto clk = static_cast<uint32_t>(main_trace.size()) + 1;
// const ExternalCallHint& hint = execution_hints.externalcall_hints.at(external_call_counter);

auto [resolved_addrs, res_error] =
Addressing<5>::fromWire(indirect, call_ptr)
Expand Down Expand Up @@ -3532,20 +3531,6 @@ AvmError AvmTraceBuilder::constrain_external_call(OpCode opcode,

pc += Deserialization::get_pc_increment(opcode);

// Crucial to perform this operation after having incremented pc because write_slice_to_memory
// is implemented with opcodes (SET and JUMP).
// Write the success flag to memory
// write_to_memory(resolved_success_offset, hint.success, AvmMemoryTag::U1);
// external_call_counter++;

// Save return data for later.
// nested_returndata = hint.return_data;

// Adjust the side_effect_counter to the value at the end of the external call but not static call.
// if (opcode == OpCode::CALL) {
// side_effect_counter = static_cast<uint32_t>(hint.end_side_effect_counter);
// }
//
// We push the current ext call ctx onto the stack and initialize a new one
current_ext_call_ctx.last_pc = pc;
current_ext_call_ctx.success_offset = resolved_success_offset,
Expand Down
1 change: 0 additions & 1 deletion barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@ class AvmTraceBuilder {
AvmMemTraceBuilder mem_trace_builder;
AvmAluTraceBuilder alu_trace_builder;
AvmBinaryTraceBuilder bin_trace_builder;
// AvmKernelTraceBuilder kernel_trace_builder;
AvmGasTraceBuilder gas_trace_builder;
AvmConversionTraceBuilder conversion_trace_builder;
AvmSha256TraceBuilder sha256_trace_builder;
Expand Down

0 comments on commit a2d556c

Please sign in to comment.