Skip to content

Commit

Permalink
comment
Browse files Browse the repository at this point in the history
  • Loading branch information
benesjan committed Nov 24, 2023
1 parent a367f02 commit 39fcd1f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ contract LiquidityMining {

// 1.c)
let block_data = get_block_data(block_number);

// TODO: This should be injected directly from kernel --> GETTING IT FROM ORACLE IS NOT SAFE!
let blocks_tree_root = block_data.blocks_tree_root;

// TODO: Seems to make sense to move the following to `HistoricBlockData` struct.
// TODO: Would make sense to unify the ordering in `HistoricBlockData::serialize` function and the ordering
Expand All @@ -118,7 +121,7 @@ contract LiquidityMining {
// In our test case this should be tree root at the latest block and should correspond to the membership
// witness we obtain from oracle
assert(
block_data.blocks_tree_root == compute_merkle_root(block_hash, witness.index, witness.path),
blocks_tree_root == compute_merkle_root(block_hash, witness.index, witness.path),
"Proving membership of a block in blocks tree failed"
);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* Autogenerated file, do not edit! */

use dep::std;
use dep::aztec::context::{ PrivateContext, PublicContext };
use dep::aztec::constants_gen::RETURN_VALUES_LENGTH;
Expand All @@ -26,6 +26,7 @@ struct ManyNotesADeepStructTestCodeGenStruct {
secret_hash: Field,
}


// Interface for calling Test functions from a private context
struct TestPrivateContextInterface {
address: Field,
Expand Down Expand Up @@ -241,6 +242,9 @@ impl TestPrivateContextInterface {
}

}




// Interface for calling Test functions from a public context
struct TestPublicContextInterface {
Expand Down Expand Up @@ -326,4 +330,5 @@ impl TestPublicContextInterface {
}

}



0 comments on commit 39fcd1f

Please sign in to comment.