fix: nightly-kind-test.yml (#8899)

Closes #8831

I briefly tried to cleanup this env mess but it got tangled, going with
the quick fix, might go back and make these not "global" at some point

.github/workflows/nightly-kind-test.yml

@@ -9,10 +9,18 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }}
-  GIT_COMMIT: ${{ github.sha }}
+  DOCKERHUB_PASSWORD: "${{ secrets.DOCKERHUB_PASSWORD }}"
+  RUN_ID: ${{ github.run_id }}
+  RUN_ATTEMPT: ${{ github.run_attempt }}
+  USERNAME: ${{ github.event.pull_request.user.login || github.actor }}
+  GITHUB_TOKEN: ${{ github.token }}
+  GH_SELF_HOSTED_RUNNER_TOKEN: ${{ secrets.GH_SELF_HOSTED_RUNNER_TOKEN }}
   AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
   AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+  BUILD_INSTANCE_SSH_KEY: ${{ secrets.BUILD_INSTANCE_SSH_KEY }}
+  GIT_COMMIT: ${{ github.event.pull_request.head.sha || github.sha }}
+  # kludge until we move away from runners
+  WAIT_FOR_RUNNERS: false
 
 jobs:
   setup:
@@ -22,79 +30,8 @@ jobs:
       runner_type: builder-x86
     secrets: inherit
 
-  changes:
-    runs-on: ubuntu-20.04
-    # Required permissions.
-    permissions:
-      pull-requests: read
-    # Set job outputs to values from filter step
-    outputs:
-      avm-transpiler: ${{ steps.filter.outputs.avm-transpiler }}
-      build-images: ${{ steps.filter.outputs.build-images }}
-      barretenberg: ${{ steps.filter.outputs.barretenberg }}
-      barretenberg-cpp: ${{ steps.filter.outputs.barretenberg-cpp }}
-      noir: ${{ steps.filter.outputs.noir }}
-      noir-projects: ${{ steps.filter.outputs.noir-projects }}
-      l1-contracts: ${{ steps.filter.outputs.l1-contracts }}
-      non-docs: ${{ steps.filter.outputs.non-docs }}
-      non-misc-ci: ${{ steps.filter.outputs.non-misc-ci }}
-      non-barretenberg-cpp: ${{ steps.filter.outputs.non-barretenberg-cpp }}
-    steps:
-      - uses: actions/checkout@v4
-        with: { ref: "${{ env.GIT_COMMIT }}" }
-      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36
-        id: filter
-        with:
-          filters: |
-            barretenberg:
-              - 'barretenberg/**'
-            barretenberg-cpp:
-              - 'barretenberg/cpp/**'
-            build-images:
-              - 'build-images/**'
-            noir:
-              - 'noir/**'
-            avm-transpiler:
-              - 'avm-transpiler/**'
-            l1-contracts:
-              - 'l1-contracts/**'
-            noir-projects:
-              - 'noir-projects/**'
-            non-barretenberg-cpp:
-              - '!(barretenberg/cpp/**)'
-              # don't consider AVM stuff 'core bb'
-              - barretenberg/cpp/pil/**
-              - barretenberg/cpp/src/barretenberg/vm/**
-              - barretenberg/cpp/src/barretenberg/**/generated/*
-              - barretenberg/cpp/src/barretenberg/client_ivc.{hpp,cpp}
-            non-docs:
-              - '!(docs/**)'
-            non-misc-ci:
-              - '!(.github/**)'
-              # Always rebuild when this file changes
-              - .github/workflows/ci.yml
-
-  build-images:
-    needs: [setup, changes]
-    # Note we don't but the 'if' here as that would also apply to dependent jobs, instead we just copy it into each step
-    runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
-    steps:
-      - uses: actions/checkout@v4
-        if: ${{ needs.changes.outputs.build-images == 'true' }}
-        with: { ref: "${{ env.GIT_COMMIT }}" }
-      - uses: ./.github/ci-setup-action
-        if: ${{ needs.changes.outputs.build-images == 'true' }}
-        with:
-          concurrency_key: build-images-x86
-      - name: "Push Build Images If Changed"
-        if: ${{ needs.changes.outputs.build-images == 'true' }}
-        timeout-minutes: 40
-        run: |
-          earthly-ci --push ./build-images/+build
-
   build:
-    needs: [build-images, changes]
-    if: ${{ needs.changes.outputs.non-docs == 'true' && needs.changes.outputs.non-misc-ci == 'true' && needs.changes.outputs.non-barretenberg-cpp == 'true' }}
+    needs: setup
     runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
     outputs:
       e2e_list: ${{ steps.e2e_list.outputs.list }}
@@ -112,8 +49,7 @@ jobs:
           earthly-ci ./yarn-project+export-e2e-test-images
 
   test:
-    needs: [build, changes]
-    if: ${{ needs.changes.outputs.non-barretenberg-cpp == 'true' }}
+    needs: build
     runs-on: ubuntu-20.04
     strategy:
       matrix: