Skip to content

Commit

Permalink
fix(pxe): Best effort noir call stack generation (#7336)
Browse files Browse the repository at this point in the history
Resolves #7188
  • Loading branch information
sirasistant authored Jul 16, 2024
1 parent 457a115 commit 0c7459b
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions yarn-project/pxe/src/pxe_service/pxe_service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -724,8 +724,14 @@ export class PXEService implements PXE {
);
const noirCallStack = err.getNoirCallStack();
if (debugInfo && isNoirCallStackUnresolved(noirCallStack)) {
const parsedCallStack = resolveOpcodeLocations(noirCallStack, debugInfo);
err.setNoirCallStack(parsedCallStack);
try {
const parsedCallStack = resolveOpcodeLocations(noirCallStack, debugInfo);
err.setNoirCallStack(parsedCallStack);
} catch (err) {
this.log.warn(
`Could not resolve noir call stack for ${originalFailingFunction.contractAddress.toString()}:${originalFailingFunction.functionSelector.toString()}: ${err}`,
);
}
}
await this.#enrichSimulationError(err);
}
Expand Down

0 comments on commit 0c7459b

Please sign in to comment.