Update burgs-and-states.js #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khanate title for Mongolian Empires and Kingdoms, Khaganate for Turkic.
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I think there was a problem with Khanate and Khaganate's Form Name Generation. I've fixed it. |
I also added Beylik form name Generation.
Azgaar
reviewed
Mar 5, 2024
modules/burgs-and-states.js
Outdated
| @@ -859,9 +859,10 @@ window.BurgsAndStates = (function () { | |||
| if (P(0.3) && s.diplomacy.includes("Vassal")) return "Protectorate"; // some vassals | |||
| } | |||
|
|
|||
| if (base === 16 && (form === "Empire" || form === "Kingdom")) return "Khaganate"; // Turkic | |||
| if (base === 31 && (form === "Empire" || form === "Kingdom")) return "Khanate"; // Mongolian | |||
| if (base === 31 && (form === "Principality" )) return "Beylik"; // Turkic | |||
|
Khanate and Khaganate is basically the same, but we can keep it separate it if want, just fix the id, please |
|
Fixed It! |
|
SOmebody Please Merge this. |
|
Actually need to update the version as well |
|
How do you do that? I'm kind of new. |
|
Not a problem, I can do it |
|
thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Khanate title for Mongolian Empires and Kingdoms, Khaganate for Turkic.
Description
Type of change
Versioning