APIGOV-27681 - event generator updates for processing #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jcollins-axway
commented
Dec 4, 2024
jcollins-axway
commented
- create event report interface and builder to help create it
- add new processor to receive the event report and create transaction events
- use event report in old create event methods to synchronize logic of all processors
- cleanup from linting warnings
jcollins-axway
requested review from
dfeldick,
sbolosan,
vivekschauhan,
alrosca and
dgghinea
as code owners
sbolosan
reviewed
Jan 13, 2025
| return beat.Event{}, errors.New("an event was not created") | ||
| } | ||
| if len(events) > 1 { | ||
| return events[0], errors.New("unexpectedly, more than one event was created, only returning the first") |
There was a problem hiding this comment.
since we are getting only the first one, regardless of if theres more than 1, should this just warn in the if statement, and then fall through to the final return?
There was a problem hiding this comment.
...unless you really really wanted to return an error?
There was a problem hiding this comment.
that would be the agent implementations issue here, the sdk should not enforce that
sbolosan
approved these changes
Jan 13, 2025
vivekschauhan
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.