APIGOV-28410 usage reports on schedule #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrosca
requested review from
jcollins-axway,
dfeldick,
sbolosan,
vivekschauhan and
dgghinea
as code owners
jcollins-axway
previously approved these changes
Sep 9, 2024
| @@ -233,8 +235,11 @@ func (c *usagePublisher) Ready() bool { | |||
|
|
|||
| // Execute - process the offline report generation | |||
| func (c *usagePublisher) Execute() error { | |||
| if c.offline { | |||
| return c.report.saveReport() | |||
| if c.report.shouldPublish(c.schedule) { | |||
There was a problem hiding this comment.
Should we move down this check to limit only sendReport and not to saveReport?
There was a problem hiding this comment.
I think it could make sense how it is, as then offline reports will not be updated any extra either. Thoughts?
jcollins-axway
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.