APIGOV-DG000 - fix ARD creation #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgghinea
requested review from
jcollins-axway,
dfeldick,
sbolosan,
vivekschauhan and
alrosca
as code owners
jcollins-axway
previously approved these changes
Aug 8, 2024
sbolosan
reviewed
Aug 8, 2024
| @@ -117,6 +117,9 @@ func (s *ServiceBody) GetAccessRequestDefinition() *management.AccessRequestDefi | |||
| } | |||
|
|
|||
| func (s *ServiceBody) createAccessRequestDefinition() error { | |||
| if !s.uniqueARD { | |||
| return nil | |||
There was a problem hiding this comment.
can you log s.ardName before you return since we are bailing right out
There was a problem hiding this comment.
Thinking debug level? Since this would happen a lot I think Warn and Info would not apply. More so since this only happens when the user said the ard is not unique for this api.
There was a problem hiding this comment.
that's reasonable... i'm down with that
sbolosan
previously approved these changes
Aug 9, 2024
jcollins-axway
previously approved these changes
Aug 9, 2024
vivekschauhan
approved these changes
Aug 12, 2024
jcollins-axway
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag that ignores creating ARD and CRDs based on the spec provided in the serviceBody