APIGOV-28475 - TA config optimization #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vivekschauhan
commented
Aug 6, 2024
vivekschauhan
commented
- Deprecate USAGEREPORTING_INTERVAL
- New config for setting schedule for metric event, default to an hour
- Remove TRACEABILITY_SAMPLING_REPORTALLERRORS
- Added TRACEABILITY_SAMPLING_ONLYERRORS, default to false, when set only errors are sampled
- Updated sampling counting to include errors
- Deprecate USAGEREPORTING_INTERVAL - New config for setting schedule for metric event, default to an hour - Remove TRACEABILITY_SAMPLING_REPORTALLERRORS - Added TRACEABILITY_SAMPLING_ONLYERRORS, default to false, when set only errors are sampled - Updated sampling counting to include errors
vivekschauhan
requested review from
jcollins-axway,
dfeldick,
sbolosan,
alrosca and
dgghinea
as code owners
| @@ -25,7 +25,7 @@ type Sampling struct { | |||
| Percentage float64 `config:"percentage"` | |||
| PerAPI bool `config:"per_api"` | |||
| PerSub bool `config:"per_subscription"` | |||
| ReportAllErrors bool `config:"reportAllErrors" yaml:"reportAllErrors"` | |||
| OnlyErrors bool `config:"onlyErrors" yaml:"onlyErrors"` | |||
jcollins-axway
previously approved these changes
Aug 6, 2024
sbolosan
previously approved these changes
Aug 6, 2024
- Deprecate CENTRAL_USAGEREPORTING_USAGESCHEDULE - Added CENTRAL_USAGEREPORTING_SCHEDULE
vivekschauhan
dismissed stale reviews from sbolosan and jcollins-axway
via
a650e2f
sbolosan
previously approved these changes
Aug 7, 2024
sbolosan
previously approved these changes
Aug 7, 2024
jcollins-axway
previously approved these changes
Aug 7, 2024
jcollins-axway
previously approved these changes
Aug 8, 2024
sbolosan
previously approved these changes
Aug 8, 2024
jcollins-axway
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.