Ampgw 879 #519
Merged
Ampgw 879 #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble/disable AgentStatusUpdate jobs.
…ble/disable AgentStatusUpdate jobs.
jcollins-axway
previously approved these changes
Aug 18, 2022
pkg/config/agentfeaturesconfig.go
Outdated
| @@ -24,6 +25,7 @@ type AgentFeaturesConfiguration struct { | |||
| PersistCache bool `config:"persistCache"` | |||
| MarketplaceProvisioning bool `config:"marketplaceProvisioning"` | |||
| ExternalIDPConfig ExternalIDPConfig `config:"idp"` | |||
| SdkAgentStatusUpdates bool `config:"sdkAgentStatusUpdates"` | |||
There was a problem hiding this comment.
Can this be changed to enableAgentStatusUpdates?
There was a problem hiding this comment.
Can we rename it as agentStatusUpdates without the "enable" to be consistent with all the other flags like (versionChecker, marketplaceProvisioning, connectToCentral , ...)?
There was a problem hiding this comment.
I agree that we should drop enable from the name.
jcollins-axway
previously approved these changes
Aug 22, 2022
vivekschauhan
approved these changes
Aug 22, 2022
vivekschauhan
previously approved these changes
Aug 23, 2022
pkg/config/agentfeaturesconfig.go
Outdated
| @@ -90,17 +99,19 @@ func AddAgentFeaturesConfigProperties(props properties.Properties) { | |||
| props.AddBoolProperty(pathVersionChecker, true, "Controls whether the agent SDK version checker will be enabled or not") | |||
| props.AddBoolProperty(pathPersistCache, false, "Controls whether the agent SDK will persist agent cache or not") | |||
| props.AddBoolProperty(pathMarketplaceProvisioning, false, "Controls whether the agent should handle Marketplace Subscriptions or not") | |||
| props.AddBoolProperty(pathEnableAgentStatusUpdates, false, "Controls whether the agent should manage the status update or not") | |||
There was a problem hiding this comment.
The default here should be true
wkolsi
dismissed stale reviews from vivekschauhan and jcollins-axway
via
d69f923
vivekschauhan
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added this flag which is true by default, so that we can on the GovernanceAgent side manage the status, but we keeping the periodic status update.