Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIGOV-22850 - one api service instance per stage #486

Merged
merged 15 commits into from
Jul 14, 2022
Merged

APIGOV-22850 - one api service instance per stage #486

merged 15 commits into from
Jul 14, 2022

Conversation

jcollins-axway
Copy link
Collaborator

  • Only create 1 api service instance per stage, update it to point to latest revision
  • Migration code to clean old instances, all but latest one per stage, within a service
  • Config option to enable the migration, default off

@jcollins-axway jcollins-axway marked this pull request as draft July 13, 2022 17:21
@jcollins-axway
Copy link
Collaborator Author

@vivekschauhan @tsjohns9 @sbolosan @dfeldick - still working on adding unit tests for the migration code, please have a look and raise issues as this is pending for Engie.

sbolosan
sbolosan previously approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@sbolosan sbolosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the combination of migrations!

sbolosan
sbolosan previously approved these changes Jul 13, 2022
View reviewed changes
vivekschauhan
vivekschauhan previously approved these changes Jul 13, 2022
View reviewed changes
pkg/apic/apiserviceinstance.go Outdated Show resolved Hide resolved
@jcollins-axway jcollins-axway dismissed stale reviews from vivekschauhan and sbolosan via 4f1627a July 14, 2022 15:03
sbolosan
sbolosan previously approved these changes Jul 14, 2022
View reviewed changes
sbolosan
sbolosan previously approved these changes Jul 14, 2022
View reviewed changes
@jcollins-axway jcollins-axway marked this pull request as ready for review July 14, 2022 17:50
@jcollins-axway jcollins-axway merged commit 683c7ed into main Jul 14, 2022
@jcollins-axway jcollins-axway deleted the APIGOV-22850 branch July 14, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbolosan sbolosan sbolosan approved these changes

@tsjohns9 tsjohns9 tsjohns9 approved these changes

@vivekschauhan vivekschauhan vivekschauhan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-axway @vivekschauhan @tsjohns9 @sbolosan