APIGOV-01234 remove mutex in healthchecker.go #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfeldick
previously approved these changes
Jun 29, 2022
vivekschauhan
previously approved these changes
Jun 29, 2022
dfeldick
previously approved these changes
Jun 29, 2022
vivekschauhan
previously approved these changes
Jun 29, 2022
tsjohns9
changed the title
|
Hi guys, Thanks for your quick fix! I've just a little comment related to this MR: now, the statusMutex attribute of the struct statusCheck (in healthcheck/definition.go) seems to be useless and could be removed (correct me if I'm wrong). When your validation process will be passed for this fix (integrated on the main branch), could you publish a new Agent-SDK release with this fix to allow us to use a public release? Best regards, Romain BISSEY. |
vivekschauhan
approved these changes
Jun 30, 2022
sbolosan
approved these changes
Jun 30, 2022
dfeldick
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.