Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo fixes #85

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Demo fixes #85

merged 2 commits into from
Aug 29, 2024

Conversation

CodeDrivenMitch
Copy link
Collaborator

Found two fixes for running the demo application:

  • The busses were not unwrapped before instrumentation, resulting in missing bus capacity metrics
  • Fix that event handlers were - according to the processor "event handlers" tab - not part of it. This broke if an @ProcessingGroup was not specified.

The latter point made me realize there can be multiple groups under the same processor. For this case, I have made a combined identifier. The UI should be adjusted for this.

This happens, for example, with our demo application, where there is no ProcessingGroup annotation. This, before, assumed it wasn't a processor and fell back to the class name.
@CodeDrivenMitch CodeDrivenMitch requested a review from a team August 28, 2024 15:49
@CodeDrivenMitch CodeDrivenMitch self-assigned this Aug 28, 2024
@CodeDrivenMitch CodeDrivenMitch requested review from gklijs, corradom, smcvb, sandjelkovic and stefanmirkovic and removed request for a team August 28, 2024 15:49
Copy link

Copy link

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot for looking into this.

@CodeDrivenMitch CodeDrivenMitch merged commit be1199c into main Aug 29, 2024
7 of 8 checks passed
@smcvb smcvb deleted the fix/demo-fixes branch August 29, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants