Changes the buffer so that errors from the fetcher will be thrown once the buffer is empty. #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the buffer is empty.
smcvb
reviewed
May 11, 2022
...main/java/org/axonframework/extensions/kafka/eventhandling/consumer/FetchEventException.java
Outdated
Show resolved
Hide resolved
...main/java/org/axonframework/extensions/kafka/eventhandling/consumer/FetchEventException.java
Outdated
Show resolved
Hide resolved
...main/java/org/axonframework/extensions/kafka/eventhandling/consumer/RuntimeErrorHandler.java
Outdated
Show resolved
Hide resolved
...main/java/org/axonframework/extensions/kafka/eventhandling/consumer/RuntimeErrorHandler.java
Outdated
Show resolved
Hide resolved
...test/java/org/axonframework/extensions/kafka/eventhandling/consumer/FetchEventsTaskTest.java
Show resolved
Hide resolved
…ndling/consumer/FetchEventException.java Review fixes Co-authored-by: Steven van Beelen <[email protected]>
…ndling/consumer/FetchEventException.java Review fixes Co-authored-by: Steven van Beelen <[email protected]>
…ndling/consumer/RuntimeErrorHandler.java Review fixes Co-authored-by: Steven van Beelen <[email protected]>
…ndling/consumer/RuntimeErrorHandler.java Review fixes Co-authored-by: Steven van Beelen <[email protected]>
…hod and add tests for the exception through the buffer for the StreamableKafkaMessageSource.
|
SonarCloud Quality Gate failed. |
smcvb
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, exceptions while consuming from Kafka no longer are just logged but passed to the buffer. Once the buffer is empty, the exception will be thrown such that the processor will go into retry mode.
Fixes #276