Bugfix/missing xstream exception #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcvb
requested changes
Dec 10, 2021
There was a problem hiding this comment.
The changes look good, but I still have one request to make. We want to release this in 4.5.1 and for that, the PR should be merged into axon-kafka-4.5.x. If you could make that adjustment, @martink76, then we should be good to go.
Fix missed XStreamSerializer issue due to the Axon Framework 4.5.5 update
Fix XStreamSerializer issue due to the Axon Framework 4.5.5 update
martink76
force-pushed
the
bugfix/missing-xstream-exception
branch
from
d540a8f to
9437b22
Compare
|
@smcvb Thanks for the feedback. I've rebased onto axon-kafka-4.5.x. |
lfgcampos
approved these changes
Dec 10, 2021
|
Just to be sure - is there anything left I can do for this PR? |
smcvb
approved these changes
Dec 13, 2021
Yep, that was getting my attention. 😅 Thanks for the effort here, @martink76. |
|
@smcvb @lfgcampos Thank you for the support 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.