Skip to content

Commit

Permalink
Use fail-fast: false throughout consistently
Browse files Browse the repository at this point in the history
In the pullrequest.yml we use "fail-fast: false", but on main.yml we use
 "continue-on-error: true". The former is intended for matrices (which
 we use throughout) and the latter for proceeding through steps (while
 we use it for the entire job). To clarify the GHA ymls, use fail-fast:
 false throughout instead.

#enhancement/fail-fast-setting-consolidation
  • Loading branch information
smcvb committed Apr 14, 2023
1 parent 5d8c862 commit ccacaaf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ jobs:
build:
name: Test and Build on JDK ${{ matrix.java-version }}
runs-on: ubuntu-latest
continue-on-error: true # do not fail the whole job if one of the steps fails

strategy:
fail-fast: false
matrix:
include:
- java-version: 8
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pullrequest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ jobs:
name: Test and Build on JDK ${{ matrix.java-version }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
include:
- java-version: 8
Expand All @@ -16,7 +17,6 @@ jobs:
sonar-enabled: false
- java-version: 17
sonar-enabled: true
fail-fast: false # run all to the end

steps:
- name: Checkout code
Expand Down

0 comments on commit ccacaaf

Please sign in to comment.