Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for the package #29

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

b-per
Copy link
Contributor

@b-per b-per commented Feb 6, 2024

Adding some integration tests for the package. Those are manual for now and not part of CI/CD, but they can already be pretty useful for people wanting to add support for new adapters.

The tests are based on the example provided and test:

  • the logic to add the exceptions column
  • the generic test feature

I also updated the examples:

  • i moved them outside of models, otherwise they were conflicting with the integration_tests folder, when importing the parent folder as package
  • I changed some of the SQL syntax to make it work for all warehouses, removing ` and trailing , on the last line before from

Example for supported warehouses

image

image

Example for non-supported warehouse/adapter

image

@AxelThevenot
Copy link
Owner

I am really sorry for the delay, a lot of work to do on my side

I've gone through your two pull requests but not in detail yet

Do you want me to merge your Pull Request without a release or with a pre-release to wait for a deeper review before the release ?

And really hard job you made both for duckDB support and this integration test feature ! Impressive :)

@AxelThevenot AxelThevenot self-requested a review February 8, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants