Skip to content

Commit

Permalink
Do not register LLVMSupport as a library when it should be a component (
Browse files Browse the repository at this point in the history
root-project#11703)

Do not register LLVMSupport as a library when it should be a component

LLVM component must be registered as LLVM_LINK_COMPONENTS to be
compatible with LLVM Dylib. Otherwise they are loaded twice in the final
binary, once through LLVM Dylmib and once through individual component,
and this results in some options being registered twice.

Fix root-project/cling#440
  • Loading branch information
vgvassilev authored Jan 20, 2023
1 parent 8199acd commit 286d96b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions interpreter/cling/tools/driver/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
# Keep symbols for JIT resolution
set(LLVM_NO_DEAD_STRIP 1)

set(LLVM_LINK_COMPONENTS Support)
if(BUILD_SHARED_LIBS)
set(LIBS
LLVMSupport

clangFrontendTool

Expand All @@ -25,8 +25,6 @@ if(BUILD_SHARED_LIBS)
)
else()
set(LIBS
LLVMSupport

clangASTMatchers
clangFrontendTool

Expand Down

0 comments on commit 286d96b

Please sign in to comment.