Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router) : Add some polyfills for IE #314

Merged
merged 1 commit into from
Oct 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7,041 changes: 3,739 additions & 3,302 deletions examples/context/package-lock.json

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion examples/context/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@
"dependencies": {
"@axa-fr/react-oidc-context": "^3.0.1-alpha.0",
"@axa-fr/react-oidc-context-fetch": "^3.0.1-alpha.0",
"core-js": "^3.2.1",
"oidc-client": "^1.8.2",
"react": "^16.8.6",
"react-app-rewired": "^2.1.3",
"react-dom": "^16.8.6",
"react-router": "^5.0.1",
"react-router-dom": "^5.0.1",
"recompose": "^0.30.0"
"recompose": "^0.30.0",
"whatwg-fetch": "^3.0.0"
},
"devDependencies": {
"react-scripts": "^3.0.1"
Expand Down
17 changes: 17 additions & 0 deletions examples/context/src/ie.polyfills.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import 'core-js/es/array/from';
import 'core-js/es/array/find';
import 'core-js/es/array/includes';
import 'core-js/es/array/find-index';
import 'core-js/es/array/map';

import 'core-js/es/object/assign';

import 'core-js/es/promise';
import 'core-js/es/map';

import 'core-js/es/string/repeat';
import 'core-js/es/string/pad-start';
import 'core-js/es/string/pad-end';
import 'core-js/es/string/starts-with';

import 'whatwg-fetch';
2 changes: 2 additions & 0 deletions examples/context/src/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import React from 'react';
import './ie.polyfills';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce n'est pas aux projets de gérer leurs compatibilités ? En faisant ça tu forcerais une webapp à avoir du code pour IE inutilement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est dans le sample ;) donc pas dans le package final

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsy


import { render } from 'react-dom';
import { BrowserRouter as Router } from 'react-router-dom';
import { AuthenticationProvider, oidcLog } from '@axa-fr/react-oidc-context';
Expand Down
5,180 changes: 2,832 additions & 2,348 deletions examples/redux/package-lock.json

Large diffs are not rendered by default.

5,407 changes: 2,512 additions & 2,895 deletions examples/vanilla/package-lock.json

Large diffs are not rendered by default.

Loading