-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor hitlets #436
Refactor hitlets #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked only for hitlets. But good point I should check for both. |
Co-authored-by: Joran Angevaare <[email protected]>
Okay processing looks good. |
What is the problem / what does the code in this PR do
With this PR we refactor the hitlet data_type a bit.
create_hitlets_from_hits
. This gives the plugin a bit more structure and generalizes hitlets such that it can also be used more easily for other analyses. Further, this allowed to remove therefresh_hit_to_hitlets
.This PR goes together with #463.