Allow re-compression at copy to frontend #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrylmasson
approved these changes
Mar 24, 2021
strax/context.py
Outdated
| run_id: str, | ||
| target: str, | ||
| target_frontend_id: int = None, | ||
| target_compressor: str = None, |
There was a problem hiding this comment.
Is it worth considering passing non-null but type-correct "empty" default args here? So an empty string for the target_compressor and something equivalent for target_frontend_id?
There was a problem hiding this comment.
sure, let me change the typecasting to typing.Optional[str]
There was a problem hiding this comment.
Alright, fixed in f8e0809
See typing.Optional for the documentation: https://docs.python.org/3/library/typing.html#typing.Optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Allow re-compression when transferring from one frontend to the other.
Can you briefly describe how it works?
If the optional argument for a compressor is specified, use that as the compression algorithm by changing the metadata.
Can you give a minimal working example (or illustrate with a figure)?
https://github.com/XENONnT/analysiscode/blob/master/StraxTests/Copy_to_frontend_and_recompress.ipynb