improve mongo-backend-loading #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f5814b.
darrylmasson
suggested changes
Oct 22, 2020
strax/storage/mongo.py
Outdated
| chunks_registry = self.db[self.col_name].find( | ||
| {**query, **{"chunk_i": {'$exists':True}}}, | ||
| {"chunk_i": 1, "data": 1}) | ||
| if chunks_registry is not None: |
There was a problem hiding this comment.
find returns a Cursor, which never evaluates to None, even if the cursor is empty. The pymongo documentation doesn't really give us much to go on for this.
There was a problem hiding this comment.
Thanks, changed it
strax/storage/mongo.py
Outdated
| f'Projection failed, got doc with no "chunk_i":\n{doc}') | ||
| # Update our registry with this chunks info. Use chunk_i as | ||
| # chunk_key | ||
| self.chunks_registry[chunk_key] = doc.copy() |
There was a problem hiding this comment.
Integers as dictionary keys can cause issues later if you try to json-encode it. Probably not an issue here, but something to remember.
There was a problem hiding this comment.
I changed it just to be on the safe side
darrylmasson
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Slightly tweak w.r.t. #335 (and #315). Only query the database for chunks once.
Can you briefly describe how it works?
Use
findto find all chunks, save it in ram and load it from there instead of doing up to 600 queries.Performance
Using
Before
23 s ± 175 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
After
1.91 s ± 70.6 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)