Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fix for zero division error - and Travis issues #321

Merged
merged 7 commits into from
Oct 8, 2020

Conversation

JoranAngevaare
Copy link
Contributor

@JoranAngevaare JoranAngevaare commented Oct 7, 2020

What is the problem / what does the code in this PR do
Quick patch to an error we encountered in one of the latest runs. Although strange we shouldn't make this kind of errors cause the entire stack of the processing crash.

Can you briefly describe how it works?
don't do x/0

Edit after all the commits you can see in this PR
Should have renamed this PR to 'fix travis issues'. This was the colateral damage:

  • Apparently travis has started running with multiple threads. This means that we cannot rely on the old counting of threads.
  • Secondly we ran into one of the conditional entropy tests. I slightly relaxed the math.isclose requirement.

@JoranAngevaare
Copy link
Contributor Author

Okay something is broken in the mailbox test. Look at 629f79e. This is not at all an issue related to PR..

@JoranAngevaare JoranAngevaare changed the title quick fix for zero division error quick fix for zero division error - and Travis issues Oct 7, 2020
@JoranAngevaare
Copy link
Contributor Author

Ok as this is a trivial PR I'm merging it.

@JoranAngevaare JoranAngevaare merged commit 98da471 into master Oct 8, 2020
@JoranAngevaare JoranAngevaare deleted the fix_zero_division branch October 8, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant