New hitlets data_kind #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add, I have just started to look into hypothesis test. But I would like to add some. |
JoranAngevaare
approved these changes
Aug 14, 2020
JoranAngevaare
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
it has been quite some time since my last PR XENONnT/straxen#86 for the nVETO plugins in straxen and many things have changed. Back then, Jelle and Joran asked me to change some of my code so that it would build up more on already existing starx functions. The two major point were:
get_hitlets_datasuch that it is based onrecord_linksandoverlapping_indicesrather than new custom made code.In addition, based on my work in the analysis Team B and Fast Response Team I noticed, that many of the functions which will be used by the nVETO are also useful to very low level analyses for the TPC. Therefore, I decided to add a more generic data_kind called hitlets with a coresponding submodul to strax rather than having the functions next to the straxen plugins. Hitlets are an extension of the already existing hits which allow to fully characterize PMT signals for SPE, DPE or lone_hitlet analyses or the operation of the neutron-veto. Beside these use cases I think also smaller TPC could benefit from this work.
Not all functions have been implemented yet (e.g. the conditional_entropy) is still missing, but since this PR is rather large I decided to open it already now. Please let me know your thoughts and comments. Once all issues are solved I can proceed and update the corresponding plugins.