Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

St.select_runs for strax.SaveWhen = Never does not make sense #379

Closed
JoranAngevaare opened this issue Jan 13, 2021 · 0 comments · Fixed by #387
Closed

St.select_runs for strax.SaveWhen = Never does not make sense #379

JoranAngevaare opened this issue Jan 13, 2021 · 0 comments · Fixed by #387

Comments

@JoranAngevaare
Copy link
Contributor

Either warn or don't do this because it makes little sense to show that we don't have something that is not stored.
JoranAngevaare added a commit to JoranAngevaare/strax that referenced this issue Jan 25, 2021
@JoranAngevaare
Warn for non saved plugins, fix AxFoundation#379
1b09900
@JoranAngevaare JoranAngevaare linked a pull request Jan 25, 2021 that will close this issue
Warn for non saved plugins, fix #379 #387
Merged
JoranAngevaare added a commit that referenced this issue Jan 28, 2021
@JoranAngevaare
Merge pull request #387 from jorana/non_saved_targets
e9d3778 
Warn for non saved plugins, fix #379
JoranAngevaare added a commit that referenced this issue Jan 29, 2021
@JoranAngevaare
Warn for non saved plugins, fix #379
596b6f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn for non saved plugins, fix #379 JoranAngevaare/strax
1 participant
@JoranAngevaare