Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move progressbar from get_iter #354

Closed
JoranAngevaare opened this issue Nov 20, 2020 · 1 comment · Fixed by #353, #276, #296 or #386
Closed

Move progressbar from get_iter #354

JoranAngevaare opened this issue Nov 20, 2020 · 1 comment · Fixed by #353, #276, #296 or #386

Comments

@JoranAngevaare
Copy link
Contributor

I think the progressbar (60 lines) makes get_iter a little convoluted:
https://github.com/AxFoundation/strax/blob/master/strax/context.py#L928

Perhaps we should try to make it a little simpler/transparent. It should not have be such complicated part of the code. It may well go into it's own function.

I think it could be as easy as just a wrapper around the function that you otherwise replace by a dummy wrapper.
This was linked to pull requests Nov 20, 2020
Fix error progress_bar #353
Merged
Patch progress bar #276
Merged
Small progress-bar bug fix #296
Merged
@WenzDaniel
Copy link
Collaborator

Sure, I kind of agree. Do you have any suggestions?

@JoranAngevaare JoranAngevaare linked a pull request Jan 24, 2021 that will close this issue
very small simplification of pbar #386
Merged
JoranAngevaare added a commit to JoranAngevaare/strax that referenced this issue Jan 25, 2021
@JoranAngevaare
fix issue AxFoundation#354 for pbar
ad7ab40
JoranAngevaare added a commit that referenced this issue Jan 25, 2021
@JoranAngevaare
Merge pull request #386 from jorana/simple_pbar
68bdc38 
very small simplification of pbar, Fix #354
JoranAngevaare added a commit that referenced this issue Jan 29, 2021
@JoranAngevaare
fix issue #354 for pbar
68c8082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JoranAngevaare @WenzDaniel