Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListBetaTesters.Fields #80

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

yonaskolb
Copy link
Contributor

Hey great project!
This is just a small fix I found. The field names on ListBetaTesters were incorrectly pluralised. I'm not sure if this is a pervasive problem in other types, I didn't check everywhere.

Reference https://developer.apple.com/documentation/appstoreconnectapi/list_beta_testers

@yonaskolb yonaskolb requested a review from AvdLee as a code owner April 10, 2020 13:01
Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there!

Thank you for this, I'm glad you found it and pushed a fix 💪

@SwiftLeeBot
Copy link
Collaborator

Messages
📖

View more details on Bitrise

📖 AppStoreConnect-Swift-SDK: Executed 149 tests, with 0 failures (0 unexpected) in 0.628 (1.181) seconds

AppStoreConnect_Swift_SDK.framework: Coverage: 81.63

File Coverage
ListBetaTesters.swift 100.0%

Generated by 🚫 Danger Swift against 0b396e0

@AvdLee AvdLee merged commit 5ffcf70 into AvdLee:master Apr 14, 2020
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.0.2 🚀

@yonaskolb yonaskolb deleted the betaTester_attributes branch April 14, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants