Support individual keys in SDK #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
SwiftLint found issues
Generated by 🚫 Danger Swift against b20f100 |
AvdLee
approved these changes
Jul 15, 2024
polpielladev
force-pushed
the
feature/support-individual-keys
branch
from
f5a69ea to
b20f100
Compare
Good point, I will make sure I add some tests in a future PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the SDK only supports team keys, but the App Store Connect API offers the possibility of creating and using individual keys with the same permissions as the user to authenticate requests.
Individual keys do not have the
issfield in the JWT's payload but they instead have asubfield: https://developer.apple.com/documentation/appstoreconnectapi/generating_tokens_for_api_requests#4313913. This PR makes backwards-compatible changes to allow developers to authenticate requests with an individual API key.