Fix date parsing for certain environments #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 users (in a certain company where I work, which is a very small fraction of users) who experienced this issue, they had some specific environment, we did not check which environment they had or why this code works, we only know that it solves the issue
|
Note: got the "All checks have failed", instantly after creating a PR, maybe a glitch on CI |
Running now, I have to manually approve CI runs on Bitrise, unfortunately. |
AvdLee
approved these changes
Apr 9, 2024
Code Coverage Report
SwiftLint found issues
Generated by 🚫 Danger Swift against 2ca8b65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 users (in a certain company where I work, which is a very small fraction of users) who experienced this issue, they had some specific environment, we did not check which environment they had or why this code works, we only know that it solves the issue.
The fix may look bad, since it's the 4th way of parse the date, however, there were already 3 ways of parsing it. The reason I make this PR is that it would be great to not use a fork of this repository in our company.